Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ApplicationId parameter to get- and remove-azRoleAssignment cmdlets #26890

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding ApplicationId parameter to get- and remove-azRoleAssignment cmdlets #26890

wants to merge 2 commits into from
+4 −4

Conversation

SebastianClaesson
Copy link
Contributor

Description

Adding ApplicationId parameter, with aliases;

  • SPN
  • ServicePrincipalName

Related to issue; #26889

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@SebastianClaesson
Update RemoveAzureRoleAssignmentCommand.cs
1ddbc00 
Adding ApplicationId parameter, with aliases; 
- SPN
- ServicePrincipalName
@SebastianClaesson
Update GetAzureRoleAssignmentCommand.cs
d475649 
Adding ApplicationId parameter, with aliases; 
- SPN
- ServicePrincipalName
@azure-client-tools-bot-prd azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Dec 17, 2024 •
edited
Loading

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Az.Blueprint
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.CosmosDB
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Az.MachineLearning
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Az.Resources
❌Build
❌PowerShell Core - Windows
Type Code Position Detail
❌ CS0103 D:\a_work\1\s\src\Resources\Resources\RoleAssignments\RemoveAzureRoleAssignmentCommand.cs(186,27) The name 'ServicePrincipalName' does not exist in the current context [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0103 D:\a_work\1\s\src\Resources\Resources\RoleAssignments\GetAzureRoleAssignmentCommand.cs(237,27) The name 'ServicePrincipalName' does not exist in the current context [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌Windows PowerShell - Windows
Type Code Position Detail
❌ CS0103 D:\a_work\1\s\src\Resources\Resources\RoleAssignments\RemoveAzureRoleAssignmentCommand.cs(186,27) The name 'ServicePrincipalName' does not exist in the current context [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
❌ CS0103 D:\a_work\1\s\src\Resources\Resources\RoleAssignments\GetAzureRoleAssignmentCommand.cs(237,27) The name 'ServicePrincipalName' does not exist in the current context [D:\a_work\1\s\src\Resources\Resources\Resources.csproj]
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows

@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Thank you for your contribution SebastianClaesson! We will review the pull request and get back to you soon.

@VeryEarly VeryEarly self-assigned this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VeryEarly VeryEarly

Labels
customer-reported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SebastianClaesson @VeryEarly